[KEDA] Update helm values to work from v2.14.0 #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vumdao
requested review from
aws-ia-ci,
parkand1,
shapirov103,
youngjeong46,
elamaran11 and
a team
as code owners
elamaran11
requested changes
Jun 20, 2024
shapirov103
reviewed
Jun 20, 2024
There was a problem hiding this comment.
Thank you for this contribution!
podSecurityContextFsGroup as well as security context fields: they are not supported by the version that is now the default version, let's add deprecation to these fields and a note that these have no effect for version 2.14 and above.
There is also impact to docs/addons/keda.md, but you can defer it.
Other than that looks great.
|
/do-e2e-tests |
1 similar comment
|
/do-e2e-tests |
elamaran11
approved these changes
Jun 21, 2024
aws-ia-ci
requested changes
Jun 21, 2024
aws-ia-ci
requested changes
Jun 21, 2024
|
Failure in e2e unrelated to the changes here. I will create a PR to fix them and rerun. |
|
/do-e2e-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Since v2.14.0, #625 updates some Helm chart values that are not backward compatible with the old settings. The serviceAccount has been separated per service, such as operator, metricServer, and webhooks.This causes the upgrade to v2.14.0+ to recreate the new operator serviceAccount without the IAM role annotation
Description of changes:
irsaRolecondition check to avoid CDK deletekedanamespace if we change irsaRole[] to emptyserviceAccounttoserviceAccount.operatorBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.